Transparent background for tooltips, dropdowns etc. #1583

Ciantic · 2021-02-11T22:07:56Z

Goal is to allow create overlay windows, such as tooltips, dropdowns etc. by simply setting the backround of the window to transparent. It also allowes to do windows without decorations (#427) and would be better way for creating overlay widgets (#1577). Additionally #1249.

https://xi.zulipchat.com/#narrow/stream/147926-druid/topic/Semi-transparent.20windows.20without.20titlebars

For instance transparency is required to make tooltip shaped window:

Or dropdown window with custom shadows:

Or if you want to make your UI go full WinAmp style from 90's:

New API for window builder transparent:

    let main_window = WindowDesc::new(build_root_widget())
        .title("Hello World!")
        .transparent(true) // <-- NEW SETTING HERE
        .window_size((400.0, 400.0));

To get fully transparent background, hide also the title bar with show_titlebar(false).

Changes include a simple example in examples/transparency.rs, currently it renders a test widget like this on a transparent background:

Note about Windows 10 code changes: This feature is not supposed to change any behavior of non-transparent windows at all, the opaque windows still should use the same code as before.

The method I chose follows this tutorial: "Windows with C++ : High-Performance Window Layering Using the Windows Composition Engine", it's the most recent, I asked about that in window-rs repo.

Included are Mac support by @rjwittams, and Linux (GTK) support by @JAicewizard. X11 and web support is stubbed.

druid-shell/src/platform/windows/keyboard.rs

druid-shell/src/platform/windows/window.rs

druid/examples/transparency.rs

druid/src/app.rs

JAicewizard · 2021-02-12T15:18:31Z

you should also ad stubs for any unsupported platform

druid-shell/src/platform/windows/window.rs

Ciantic · 2021-02-14T18:25:54Z

This is now ready for review 🚢, only thing I'm annoyed is the amount of commits there, I think we can't squash this as there are contributions from others, and GitHub doesn't allow squashing only some from the older commits?

I'm trying to re-base this so that commits from different people are not squashed.

JAicewizard · 2021-02-14T18:51:39Z

local squash + force push ;)

Ciantic · 2021-02-14T19:25:08Z

I'm rebasing this, currently a total mess.

Ciantic · 2021-02-14T20:06:03Z

Now I have rebased / squashed this.

I think it's now final. 🚢

Ciantic · 2021-02-14T21:57:08Z

Note for posterity, we removed two spurious println! lines with force push right there. The Github log doesn't make this very clear if we don't do real commits.

Ciantic · 2021-02-14T22:00:33Z

@cmyr I think this is ready for review.

raphlinus · 2021-02-16T19:04:00Z

This causes failure on Windows 7, STATUS_DLL_NOT_FOUND in particular. I haven't investigated in detail, but it's most likely the dependency on DirectComposition. Since it's not supported on Windows 7, it needs to be loaded as optional functions. That existed for a long while but was removed in #1191, specifically commit 290f6e4.

Ciantic · 2021-02-16T19:11:41Z

Okay we discussed this in Zulip, I'll change the Windows part to make the dependency to composition parts optional.

Ciantic · 2021-02-16T21:18:01Z

It's all green again 🟢. I don't have Windows 7 to test, and looks like the CI doesn't test that either, but when you've got time give it a test on Win 7.

If it doesn't work, I may have to get Win 7 running in vbox, I don't want to bother you to test the compilation after my changes.

raphlinus · 2021-02-16T21:36:51Z

It works as expected on 7 - hello works fine, and the "transparency" example isn't transparent but is otherwise functional. You might consider logging a warning in that case. So this is unblocked on me, but still requires someone to review in all the PR's glorious detail.

Web stub implementation to allow compilation Signed-off-by: Jari Pennanen <ciantic@oksidi.com>

Signed-off-by: Jari Pennanen <ciantic@oksidi.com>

Ciantic · 2021-02-16T22:09:07Z

I added the warning if user is using Win 7 and tries transparent, and rebased, squashed my win 7 fix changes.

cmyr

This looks good to me, a few little observations inline but nothing blocking.

I'm curious if this has been tested on multiple monitors, at all; that seems like a possible source of complications. I'm also slightly scared of macOS, and I'll test again on my laptop with a second monitor when I get home later tonight.

Thanks in any case, this should unblock a lot of other work!

druid-shell/src/platform/windows/window.rs

druid/examples/transparency.rs

Ciantic · 2021-02-17T22:07:43Z

I pushed some changes.

cmyr · 2021-02-18T02:02:30Z

Okay, this looks good to me, thanks again!

* Windows with transparent background * Mac support for transparency Web stub implementation to allow compilation Signed-off-by: Jari Pennanen <ciantic@oksidi.com> * add transparance on linux!!! Signed-off-by: Jari Pennanen <ciantic@oksidi.com> * Win 7 transparency fix: optionalize DCompositionCreateDevice * Transparency touch-ups Co-authored-by: Robert Wittams <robert@wittams.com> Co-authored-by: jaap aarts <jaap.aarts1@gmail.com>

Ciantic commented Feb 11, 2021

View reviewed changes

druid-shell/src/platform/windows/keyboard.rs Outdated Show resolved Hide resolved

Ciantic mentioned this pull request Feb 12, 2021

Transparent Window Background Color #1249

Closed

JAicewizard reviewed Feb 12, 2021

View reviewed changes

druid-shell/src/platform/windows/window.rs Outdated Show resolved Hide resolved

Ciantic mentioned this pull request Feb 12, 2021

Transparent background for d2d examples? microsoft/windows-rs#541

Closed

Ciantic marked this pull request as ready for review February 14, 2021 11:54

Ciantic mentioned this pull request Feb 14, 2021

Fully transparent color linebender/piet#397

Merged

Ciantic force-pushed the master branch from 852b29b to 7fab3ac Compare February 14, 2021 19:21

Ciantic marked this pull request as draft February 14, 2021 19:24

Ciantic force-pushed the master branch from 7fab3ac to 70f948b Compare February 14, 2021 19:53

Ciantic marked this pull request as ready for review February 14, 2021 20:05

Ciantic force-pushed the master branch from 147febc to dfe0012 Compare February 14, 2021 21:29

Ciantic requested a review from cmyr February 14, 2021 22:00

cmyr added the S-needs-review waits for review label Feb 15, 2021

This was linked to issues Feb 16, 2021

Windows without decorations #427

Closed

Overlay Widgets #1577

Closed

Transparent Window Background Color #1249

Closed

Ciantic and others added 2 commits February 16, 2021 23:38

Windows with transparent background

a002940

Mac support for transparency

1d31b25

Web stub implementation to allow compilation Signed-off-by: Jari Pennanen <ciantic@oksidi.com>

add transparance on linux!!!

85757fa

Signed-off-by: Jari Pennanen <ciantic@oksidi.com>

Ciantic force-pushed the master branch 2 times, most recently from 75635ec to 1ade185 Compare February 16, 2021 22:02

Win 7 transparency fix: optionalize DCompositionCreateDevice

eb80ed2

Ciantic force-pushed the master branch from 1ade185 to eb80ed2 Compare February 16, 2021 22:04

cmyr approved these changes Feb 17, 2021

View reviewed changes

druid-shell/src/platform/windows/window.rs Show resolved Hide resolved

druid-shell/src/platform/windows/window.rs Outdated Show resolved Hide resolved

druid/examples/transparency.rs Outdated Show resolved Hide resolved

Transparency touch-ups

05aef19

cmyr merged commit 131b0a6 into linebender:master Feb 18, 2021

This was referenced Mar 1, 2021

Restore the ability to have fully transparent windows on Windows rust-windowing/winit#1815

Merged

Transparency (no back buffer support) using CreateSwapChainForComposition contribution gfx-rs/d3d12-rs#29

Closed

maan2003 removed the S-needs-review waits for review label May 3, 2021

maan2003 mentioned this pull request Oct 5, 2021

examples transparency not work in windows 7 #2004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transparent background for tooltips, dropdowns etc. #1583

Transparent background for tooltips, dropdowns etc. #1583

Ciantic commented Feb 11, 2021 •

edited

Loading

JAicewizard commented Feb 12, 2021

Ciantic commented Feb 14, 2021 •

edited

Loading

JAicewizard commented Feb 14, 2021

Ciantic commented Feb 14, 2021

Ciantic commented Feb 14, 2021 •

edited

Loading

Ciantic commented Feb 14, 2021

Ciantic commented Feb 14, 2021

raphlinus commented Feb 16, 2021

Ciantic commented Feb 16, 2021 •

edited

Loading

Ciantic commented Feb 16, 2021

raphlinus commented Feb 16, 2021 •

edited

Loading

Ciantic commented Feb 16, 2021 •

edited

Loading

cmyr left a comment

Ciantic commented Feb 17, 2021

cmyr commented Feb 18, 2021

Transparent background for tooltips, dropdowns etc. #1583

Transparent background for tooltips, dropdowns etc. #1583

Conversation

Ciantic commented Feb 11, 2021 • edited Loading

JAicewizard commented Feb 12, 2021

Ciantic commented Feb 14, 2021 • edited Loading

JAicewizard commented Feb 14, 2021

Ciantic commented Feb 14, 2021

Ciantic commented Feb 14, 2021 • edited Loading

Ciantic commented Feb 14, 2021

Ciantic commented Feb 14, 2021

raphlinus commented Feb 16, 2021

Ciantic commented Feb 16, 2021 • edited Loading

Ciantic commented Feb 16, 2021

raphlinus commented Feb 16, 2021 • edited Loading

Ciantic commented Feb 16, 2021 • edited Loading

cmyr left a comment

Choose a reason for hiding this comment

Ciantic commented Feb 17, 2021

cmyr commented Feb 18, 2021

Ciantic commented Feb 11, 2021 •

edited

Loading

Ciantic commented Feb 14, 2021 •

edited

Loading

Ciantic commented Feb 14, 2021 •

edited

Loading

Ciantic commented Feb 16, 2021 •

edited

Loading

raphlinus commented Feb 16, 2021 •

edited

Loading

Ciantic commented Feb 16, 2021 •

edited

Loading